csv import and export fixes #3135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds shelved and published dates for books and their imported reviews. Provides option to create new (custom) shelves when importing books. fixes bookwyrm-social#3004 fixes bookwyrm-social#2846 fixes bookwyrm-social#2666 fixes bookwyrm-social#2411
|
I'm not sure how to handle the merge conflicts on this one |
|
I wasn't sure how to resolve the merge conflicts on this |
|
yeah I got distracted with other things, I need to come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shelved and published dates for books and their imported reviews. Provides option to create new (custom) shelves when importing books.
fixes #3004
fixes #2846
fixes #2666
fixes #2411
I'm aware there will be a bunch of pylint and test errors on this, I'm seeking feedback from @bookwyrm-social/code-review on the general approach before finalising. In particular,
BookwyrmBookImporterrather than inImporter,