New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: move initial setup into docker startup to simplify deployment #2467
base: main
Are you sure you want to change the base?
Conversation
An example docker-compose deployment as part of the SSO v.st environment: https://git.v.st/vst/env/commit/b627e976871a93ed490c70695a54d4d7d5e99fdb |
Thank you for these PRs! I should be able to review them tomorrow or early next week |
I played around with this a little and wasn't really sure how to use it and get the entrypoint to run the setup scrip -- can you step me through how the install process works differently with this change? I appreciate your patience, I have like two braincells right now due to life business |
The idea is that a non-developer admin shouldn't need to invoke the setup script -- the If that didn't happen when you ran |
Ah, I think the piece I was missing was how to change the docker-compose file. Is that something you can include in the PR (minus the oidc changes)? |
@osresearch This is a nice addition. If you're happy to add the updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
if [ -z "$DB_INIT" ]; then | ||
while [ ! -r "$CANARY" ]; do | ||
info "**** Waiting for database and migrations to finish" | ||
sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would:
sleep 10 | |
sleep 0.5 |
since the test is very cheap.
This patch makes it easier to perform non-development installations with
docker-compose
by performing the initial setup in theweb
container on first startup (while thecelery
andflower
containers wait for it to complete).The production
docker-compose.yml
also needs an update to pull from an official image (I'm testing it with my OIDC patches in #2464 here):