Update Knex to v2.4.2 & Run npm audit #2125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing Node 10 as Knex requires at least 12, and 16 is the most recent LTS
While the fork got rid of a few unneeded dependencies, the latest knex version needs the official package in order to run the SQLite tests. Partially reverts 2baafea
The only remaining security issues are dependencies of the website, i.e. bookshelf-jsdoc-theme, which are not relevant for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Update to the latest, non-vulnerable version of the Knex query builder.
Motivation
GHSA-4jv9-3563-23j3
Proposed solution
I performed this update in two steps: First I tested the existing commits for the update to v1 from #2120, then I updated to v2 and ran the test suite again, which required me to exchange the
sqlite3package again (see 5ece77d).Finally I performed an
npm auditto update a few other dependencies with security issues.Current PR Issues
The only remaining security issues are related to dependencies of the website, i.e.
bookshelf-jsdoc-theme, which are not relevant for my (or other downstream users) use case.