Count on relation should work for belongsToMany relations. #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardograca
requested changes
Dec 9, 2020
|
Will do! |
|
@ricardograca, fixed the linter issue and added a test that seems to be passing. Not sure why the build is failing, could you take a look when you get the chance? |
|
Thanks! One of the jobs just hanged and timed out without any errors at the end, so I just restarted it. I'll check the code later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
When calling count on a relationship collection, if the relation is belongsToMany, count returns the count of the entire table instead of just the related entries. The belongsToMany case did not seem to be handled at all previously in sync.js.
Motivation
Describe the problems that this proposal seeks to address and why it's important. If it's completely new functionality
explain why this new functionality is necessary.
Proposed solution
Describe your solution to the problem. If possible provide examples and describe how they work. Show why your solution
is better than what's currently available: is it cleaner, safer, or more efficient?
Current PR Issues
Are there any known issues in this Pull Request? This will help others understand if more work will be needed.
Alternatives considered
Describe any alternative approaches to addressing the same problem that you have thought about, and why you chose this
approach instead.