Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Yarn): replaced relative path to bin with npx and first argument #254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Stradivario
Copy link

@Stradivario Stradivario commented Oct 2, 2019

Issue

Description

This issue present when we use Codeship Build process. Codeship environment has different way of linking, mapping, caching installed packages so it is not a good option to think that we will have yarn installed and linked for us. This pull request introduces simple fix using npx command.

Type of change

  • Non Breaking change

Checklist:

  • Replace relative path of yarn with npx command
  • Put yarn command inside first argument of execution inside child process
  • Fix Tests to fit new flow when using yarn with npx
  • Expected arguments inside yarn.test.js are now 2 instead of 1
  • Removed project-bin-path from dependencies since npx is more powerful

@Stradivario Stradivario force-pushed the fix-relative-path-replaced-with-npx-with-first-argument-yarn branch from f744d71 to a606726 Compare October 2, 2019 18:52
@Stradivario
Copy link
Author

@lukebatchelor @Blasz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant