Rename 'popover' to fix Chrome 114 bug

boltdesignsystem · May 31, 2023 · f774b98 · f774b98
1 parent ed398c4
commit f774b98
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/components/bolt-popover/src/popover.js b/packages/components/bolt-popover/src/popover.js
@@ -28,7 +28,7 @@ class BoltPopover extends BoltElement {
   disconnectedCallback() {
     super.disconnectedCallback && super.disconnectedCallback();
 
-    this.popover?.hide();
+    this.tippyInstance?.hide();
   }
 
   getPaddingTop() {
@@ -75,7 +75,7 @@ class BoltPopover extends BoltElement {
       : document.body;
 
     // Note: trigger cannot not be a shadow DOM element or Tippy doesn't always hide properly
-    this.popover = tippy(this.trigger, {
+    this.tippyInstance = tippy(this.trigger, {
       content: this.content,
       placement: this.placement || schema.properties.placement.default,
       trigger: this.triggerEvent === 'hover' ? 'mouseenter click' : 'click',
@@ -173,7 +173,7 @@ class BoltPopover extends BoltElement {
     // close popover when inner action is clicked
     for (const innerAction of this.content.querySelectorAll('a, button')) {
       innerAction.addEventListener('click', () => {
-        this.popover?.hide();
+        this.tippyInstance?.hide();
       });
     }
 

diff --git a/packages/components/bolt-tooltip/src/tooltip.js b/packages/components/bolt-tooltip/src/tooltip.js
@@ -26,7 +26,7 @@ class BoltTooltip extends BoltElement {
   disconnectedCallback() {
     super.disconnectedCallback && super.disconnectedCallback();
 
-    this.popover?.hide();
+    this.tippyInstance?.hide();
   }
 
   getPaddingTop() {
@@ -73,7 +73,7 @@ class BoltTooltip extends BoltElement {
       : document.body;
 
     // Note: trigger cannot not be a shadow DOM element or Tippy doesn't always hide properly
-    this.popover = tippy(this.trigger, {
+    this.tippyInstance = tippy(this.trigger, {
       content: this.content,
       placement: this.placement || schema.properties.placement.default,
       trigger: 'mouseenter focus', // To help debug styles set to 'click'