slight improvement in performance #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokub
reviewed
Dec 19, 2022
package.json
Outdated
| @@ -18,6 +18,7 @@ | |||
| "blockies": "^0.0.2", | |||
| "bootstrap": "^4.6.0", | |||
| "core-js": "^3.6.5", | |||
| "crypto": "^1.0.1", | |||
There was a problem hiding this comment.
Why use this module that has been deprecated for years instead of using the native Node.js crypto module ?
|
Thanks for this PR ! I will run some benchmarks to measure the difference |
bokub
reviewed
Dec 19, 2022
| return { | ||
| address: privateToAddress(randbytes).toString('hex'), | ||
| privKey: randbytes.toString('hex') | ||
| address: '0x' + crypto.createHash('sha3-256').update(privateKey).digest('hex').slice(24), |
There was a problem hiding this comment.
privateKey is not defined, do you mean privateKeyBytes ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few days ago I made a JS application that was able to generate 1M addresses within 10 seconds so I implemented some of its code here which may bring some sort of improvement in performance (didn't tested by own)