Skip to content

Commit

Permalink
grpcreflect.NewClient() -> grpcreflect.NewClientAuto()
Browse files Browse the repository at this point in the history
  • Loading branch information
bojand committed Jun 18, 2023
1 parent 3b7b67a commit 96b9b60
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
7 changes: 3 additions & 4 deletions protodesc/protodesc_test.go
Expand Up @@ -10,7 +10,6 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
"google.golang.org/grpc/metadata"
reflectpb "google.golang.org/grpc/reflection/grpc_reflection_v1alpha"
)

func TestProtodesc_GetMethodDescFromProto(t *testing.T) {
Expand Down Expand Up @@ -148,7 +147,7 @@ func TestProtodesc_GetMethodDescFromReflect(t *testing.T) {

refCtx := metadata.NewOutgoingContext(ctx, md)

refClient := grpcreflect.NewClient(refCtx, reflectpb.NewServerReflectionClient(conn))
refClient := grpcreflect.NewClientAuto(refCtx, conn)

mtd, err := GetMethodDescFromReflect("helloworld.Greeter.SayHello", refClient)
assert.NoError(t, err)
Expand All @@ -167,7 +166,7 @@ func TestProtodesc_GetMethodDescFromReflect(t *testing.T) {

refCtx := metadata.NewOutgoingContext(ctx, md)

refClient := grpcreflect.NewClient(refCtx, reflectpb.NewServerReflectionClient(conn))
refClient := grpcreflect.NewClientAuto(refCtx, conn)

mtd, err := GetMethodDescFromReflect("helloworld.Greeter/SayHello", refClient)
assert.NoError(t, err)
Expand All @@ -186,7 +185,7 @@ func TestProtodesc_GetMethodDescFromReflect(t *testing.T) {

refCtx := metadata.NewOutgoingContext(ctx, md)

refClient := grpcreflect.NewClient(refCtx, reflectpb.NewServerReflectionClient(conn))
refClient := grpcreflect.NewClientAuto(refCtx, conn)

mtd, err := GetMethodDescFromReflect("helloworld.Greeter/SayHelloAsdf", refClient)
assert.Error(t, err)
Expand Down
4 changes: 1 addition & 3 deletions runner/requester.go
Expand Up @@ -22,8 +22,6 @@ import (
"google.golang.org/grpc/keepalive"
"google.golang.org/grpc/metadata"

reflectpb "google.golang.org/grpc/reflection/grpc_reflection_v1alpha"

// To register the xds resolvers and balancers.
_ "google.golang.org/grpc/xds"
)
Expand Down Expand Up @@ -110,7 +108,7 @@ func NewRequester(c *RunConfig) (*Requester, error) {

refCtx := metadata.NewOutgoingContext(ctx, md)

refClient := grpcreflect.NewClient(refCtx, reflectpb.NewServerReflectionClient(cc))
refClient := grpcreflect.NewClientAuto(refCtx, cc)

mtd, err = protodesc.GetMethodDescFromReflect(c.call, refClient)
}
Expand Down

0 comments on commit 96b9b60

Please sign in to comment.