Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tarjan_test.cpp #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update tarjan_test.cpp #201

wants to merge 1 commit into from

Conversation

hxm-cpp
Copy link

@hxm-cpp hxm-cpp commented Mar 17, 2024

std::sort fix

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thank you for creating your first pull-request on the Graaf library :)

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (5b47687) to head (1a019d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          56       56           
  Lines        2586     2586           
  Branches      135      135           
=======================================
  Hits         2575     2575           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hxm-cpp, thanks for opening this PR!

It is indeed preferred to explicitly include the headers which are used, as opposed to including these transitively. Out of interest, did you have any issues building the tests without this include?

Copy link
Contributor

github-actions bot commented May 1, 2024

Marking this PR as stale. It will not be automatically closed.

Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated.
Please allow some time for @bobluppes to take a closer look.

@github-actions github-actions bot added stale and removed stale labels May 1, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

Marking this PR as stale. It will not be automatically closed.

Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated.
Please allow some time for @bobluppes to take a closer look.

@github-actions github-actions bot added stale and removed stale labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants