-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tarjan_test.cpp #201
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Thank you for creating your first pull-request on the Graaf library :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 56 56
Lines 2586 2586
Branches 135 135
=======================================
Hits 2575 2575
Misses 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hxm-cpp, thanks for opening this PR!
It is indeed preferred to explicitly include the headers which are used, as opposed to including these transitively. Out of interest, did you have any issues building the tests without this include?
Marking this PR as stale. It will not be automatically closed. Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated. |
Marking this PR as stale. It will not be automatically closed. Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated. |
std::sort fix