Legacy Coin Type flag to BLZJS #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added legacy coin flag to BlZconfig, API constructor, called legacyCoin flag in mnemonicToAddress to allow for dynamic coin type selection(legacy or new) Second path option in setPath changed to 483 coin type API legacyCoin property set properly, current error: setPath has implicitly 'any' type Fixed implicit any error properties added and legacyCoin called in setPath, setPath is considered unresolved, API still works without flag change from default, but returns nothing when flag is set changed cosmos declaration type to 'unknown' Ternary operator set in mnemonicToAddress function, legacyCoin type still works, new coin type throws an exception legacyCoin flag works when assigned true, but c.setPath does not when called on a path that includes new coin type error: pubKey does not match signer address Legacy coin flag is working, set to false by default, added getPath global function to allow address generation and signing with coin type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added legacy coin flag to BlZconfig, API constructor, called legacyCoin flag in mnemonicToAddress to allow for dynamic coin type selection(legacy or new)
Second path option in setPath changed to 483 coin type
API legacyCoin property set properly, current error: setPath has implicitly 'any' type
Fixed implicit any error
properties added and legacyCoin called in setPath, setPath is considered unresolved, API still works without flag change from default, but returns nothing when flag is set
changed cosmos declaration type to 'unknown'
Ternary operator set in mnemonicToAddress function, legacyCoin type still works, new coin type throws an exception
legacyCoin flag works when assigned true, but c.setPath does not when called on a path that includes new coin type error: pubKey does not match signer address
Legacy coin flag is working, set to false by default, added getPath global function to allow address generation and signing with coin type