[馃惔] Decrement app badge when opening unread chat #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
haileyok
commented
May 16, 2024
haileyok
commented
- Decrement the badge when opening a chat from the messages list
- Decrement the badge when opening a chat from a push notification
- Increment the badge every time you receive a notification for a chat
- EXCEPT for if it is the chat you are currently looking at
|
Your Render PR Server URL is https://social-app-pr-4040.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp2ntfe3e1ms738sm7j0. |
haileyok
force-pushed
the
hailey/decrement-badge-on-open-chat
branch
from
e5b0a20
to
b303c88
Compare
|
| if (convo.unreadCount > 0) { | ||
| // We only increment the badge once per conversation, so even if there are multiple unreads | ||
| // we only want to decrement by one. | ||
| decrementBadgeCount(1) |
There was a problem hiding this comment.
We're doing markAsRead within the ConvoProvider, could be a good spot for this too
There was a problem hiding this comment.
Yeah pry good to do there in case you foreground the app directly to the convo page
There was a problem hiding this comment.
Ahhh okay perfect let me adjust to that, wasn't sure if we did it or the server did it for us.
estrattonbailey
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.