-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃惔] Go back on account switches #4012
base: main
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://social-app-pr-4012.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp1q697jbltc738b7n1g. |
|
@@ -31,10 +32,31 @@ type Props = NativeStackScreenProps< | |||
CommonNavigatorParams, | |||
'MessagesConversation' | |||
> | |||
|
|||
let prevDid: string | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit odd having state outside of React? Shouldn't this be in a ref?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't be because the whole tree is gettin nuked when see switch accounts. Ran into the same problem with notifications as well.
Talked to Hailey about this, this is fine-ish but it would be much better to have a |
Yea this would be useful in some other notification logic too. |
No description provided.