Remove getProfile calls when loading feed
#3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3881.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cosmc3n109ks73dr04rg. |
haileyok
force-pushed
the
hailey/remove-getprofile-userinfotext
branch
from
f610de3
to
fe01005
Compare
|
haileyok
force-pushed
the
hailey/remove-getprofile-userinfotext
branch
from
825f3e6
to
0c16dba
Compare
haileyok
commented
May 7, 2024
| @@ -34,6 +34,7 @@ export const DEFAULT_LOGGED_OUT_PREFERENCES: UsePreferencesQueryResponse = { | |||
| pinned: [], | |||
| unpinned: [], | |||
| }, | |||
| savedFeeds: [], | |||
There was a problem hiding this comment.
Not sure if this is the correct move here
estrattonbailey
previously requested changes
May 7, 2024
add comments ensure only if first simplify nit handle cases where the parent is removed add a comment remove unnecessary `getProfile()` calls from feed load limit only to the first post in the returned items move the logic out of the render and into the query add the grandparent properly update `FeedItem` bump package update `FeedItem` update `post-feed` query update `FeedSlice`
gaearon
force-pushed
the
hailey/remove-getprofile-userinfotext
branch
from
2d7c37b
to
87bc522
Compare
gaearon
approved these changes
May 23, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 23, 2024
* origin/main: Remove `getProfile` calls when loading feed (#3881) Log error statuses from failed resume session calls (#4174) disable alt text auto focus on Android (#4198) [🐴] add link to chat settings from main settings (#4197) ✍️ Add OTA Docs (#4187) Decrease thickness of border on message input (#4196) [🐴] better error message for "Bad token scope" error (#4194) Add padding to dialogs when keyboard is open on Android (#4182) [🐴] Do not init event bus if no session (#4193) stop line breaks for timeelapsed (#4191) Reduce polling when app is backgrounded (#4192) implement a safari hack for ime (#4186) [🐴] Suspend event bus when switching accounts (#4190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, we make a ton of calls to
getProfile()to display the "Reply to" label. However, since bluesky-social/atproto#2461, we can now get this info from thegrandparentAuthorfield in the API response.Test Plan
Before
After
Verify that the requests are no longer present when loading your timeline. Also verify that posts properly display the
Reply tolabel when they should.Check situations where:
A normal situation
Removing the parent
Us making a thread