Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch time out #127

Merged
merged 14 commits into from
Feb 24, 2024
Merged

patch time out #127

merged 14 commits into from
Feb 24, 2024

Conversation

khufkens
Copy link
Member

@khufkens khufkens commented Feb 23, 2024

Fix for #125

Queries returned 500 errors on downloads recently. I assume rate limiting is in place due to data migration. The polling retry frequency at 5s was potentially too high. I reduced this to a default of 30s and made the variable dynamic. I also included a dynamic http code in the first query (ignored in the update status section though).

Copy link
Collaborator

@eliocamp eliocamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.24%. Comparing base (14e8e3d) to head (3744fb1).
Report is 8 commits behind head on master.

Files Patch % Lines
R/service-cds.R 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #127       +/-   ##
===========================================
+ Coverage   11.23%   53.24%   +42.00%     
===========================================
  Files          20       20               
  Lines         979      986        +7     
===========================================
+ Hits          110      525      +415     
+ Misses        869      461      -408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khufkens khufkens merged commit 534e988 into master Feb 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants