Skip to content

Commit

Permalink
fix: Remove unnecessary implements Iterable (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
spydon committed Apr 14, 2023
1 parent c71e703 commit dd5f163
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion lib/ordered_set.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'dart:collection';
/// [SplayTreeSet], it allows for several different elements with the same
/// priority to be added. It also implements [Iterable], so you can iterate it
/// in O(n).
class OrderedSet<E> extends IterableMixin<E> implements Iterable<E> {
class OrderedSet<E> extends IterableMixin<E> {
// If the default implementation of `Set` changes from `LinkedHashSet` to
// something else that isn't ordered we'll have to change this to explicitly
// be `LinkedHashSet` (or some other data structure that preserves order).
Expand Down
2 changes: 1 addition & 1 deletion scripts/analyze.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

pub get
dart pub get

result=$(pub run dart_code_metrics:metrics .)
if [ "$result" != "" ]; then
Expand Down
7 changes: 3 additions & 4 deletions scripts/coverage.sh
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
#!/bin/bash -xe

pub get
dart pub get

dart test --coverage=coverage .

pub run coverage:format_coverage \
dart pub run coverage:format_coverage \
--lcov \
--in=coverage/test/ \
--out=coverage/lcov.info \
--packages=.packages \
--report-on=lib
--report-on=lib
4 changes: 2 additions & 2 deletions scripts/dartdoc.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash

pub get
pub run dartdoc --no-auto-include-dependencies --quiet
dart pub get
dart pub run dartdoc --no-auto-include-dependencies --quiet
2 changes: 1 addition & 1 deletion scripts/format.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

pub get
dart pub get

FORMAT_ISSUES=$(dart format --output=none --set-exit-if-changed .)
if [ $? -eq 1 ]; then
Expand Down

0 comments on commit dd5f163

Please sign in to comment.