-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Publish from GitHub CI #1760
base: main
Are you sure you want to change the base?
Conversation
Indirectly blocked by dart-lang/pub#4145, but we should do this in another PR anyway. For test the workflow see: https://github.com/Gustl22/audioplayers/actions/runs/8032514104/job/21941993530 We could merge it, but for a release, we may need to do some changes / exclude the audio file with the non ascii char. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work yet unfortunately, it's blocked by dart-lang/pub-dev#7177 which is solved in dart-lang/pub-dev#7462, but it seems like it will take a while to get that landed.
uh oh, thank you for the explanation! And thank you for investing time in such a useful feature. Gave my thumbs for issue and PR :D |
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: subosito/flutter-action@v2 | ||
- name: Remove invalid pub files # TODO(gustl22): remove when fixed: https://github.com/dart-lang/pub/pull/4145 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be circumvented by adding exception --skip-validation
. See dart-lang/pub#4145 (comment)
Description
This allows publishing audioplayers from the GitHub CI.
The PR creation is available as a workflow dispatch (with option for prerelease) to not overwhelm the PR pipeline.
Checklist
fix:
,feat:
,refactor:
,docs:
,chore:
,test:
,ci:
etc).///
, where necessary.Breaking Change
Related Issues