Add keyset pagination #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as of Gitlab v17.0 'users' endpoint only uses keyset pagination. This adds support for keyset pagination. As keyset pagination returns the next page as a link in the in the HTTP response header. RESTClient.pm was changed to return http headers when called in list mode. Paginator.pm checks for the pagination='keyset' parameter or 'users' method and passes keyset parameters to GitLab API method calls. It then parses the response header for the Link header, pulling out the returned URL parameters. Storing them for the next call to next_page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyset pagination was added to Gitlab a while ago and as of
Gitlab v17.0 'users' endpoint only uses keyset pagination.
This adds support for keyset pagination.
As keyset pagination returns the next page as a link in the in the HTTP response header. RESTClient.pm was changed to return http headers when called in list mode.
Paginator.pm checks for the pagination='keyset' parameter or 'users' method and passes keyset parameters to GitLab API method calls. It then parses the response header for the Link header, pulling out the returned URL parameters. Storing them for the next call to next_page.