Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Fix parsed options #393

Merged
merged 2 commits into from Nov 3, 2021
Merged

Conversation

int3cd
Copy link
Contributor

@int3cd int3cd commented Oct 19, 2021

The package needs to be updated to resolve the bug #389 and #96

The problem comes from a parsing error. In the package protobufjs, the bug has already been fixed: protobufjs/protobuf.js#1256

@int3cd
Copy link
Contributor Author

int3cd commented Oct 29, 2021

@ggordan @rcrowe @george-angel @nylar @hectorhuertas @ffilippopoulos @redhoyasa

Do you mind to look at this?

@george-angel
Copy link
Collaborator

Apologies for the lack of response @int3cd - we are having a look now!

@int3cd
Copy link
Contributor Author

int3cd commented Oct 29, 2021

Apologies for the lack of response @int3cd - we are having a look now!

@george-angel, will you be able to make a new version 1.5.4 after you merge the branch?

@george-angel
Copy link
Collaborator

@int3cd I don't manage this project (or ever touched NodeJS in my life), the initial author of the project has left the company.

I'm trying to figure out the fate of the project internally, please bare with, I will post an update later today.

Copy link

@daylerees daylerees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built using this branch and tested. Seems to work fine. No obvious regressions. 👍 Thanks!

@int3cd
Copy link
Contributor Author

int3cd commented Nov 3, 2021

@george-angel @daylerees

Will we merge request and release a new release this week?

@george-angel
Copy link
Collaborator

@int3cd Sorry - would you mind resolving?

I will merge and have a look at creating a release.

Thanks!

@george-angel george-angel merged commit 445827d into bloomrpc:master Nov 3, 2021
@int3cd
Copy link
Contributor Author

int3cd commented Nov 16, 2021

@george-angel , can you make a new release 1.5.4?

@george-angel
Copy link
Collaborator

Hey @int3cd - please see - #398

Utility Warehouse has decided to release the project into public domain and we are looking for maintainers to look after the project.

I'm only around to hand over the reigns, so please reach out to one of the volunteers - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants