Conversation
4f7da06
to
3592e54
Compare
@ggordan @rcrowe @george-angel @nylar @hectorhuertas @ffilippopoulos @redhoyasa Do you mind to look at this? |
Apologies for the lack of response @int3cd - we are having a look now! |
@george-angel, will you be able to make a new version 1.5.4 after you merge the branch? |
@int3cd I don't manage this project (or ever touched NodeJS in my life), the initial author of the project has left the company. I'm trying to figure out the fate of the project internally, please bare with, I will post an update later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built using this branch and tested. Seems to work fine. No obvious regressions. 👍 Thanks!
Will we merge request and release a new release this week? |
@int3cd Sorry - would you mind resolving? I will merge and have a look at creating a release. Thanks! |
0013dfe
to
c9fb3d1
Compare
c9fb3d1
to
f00c6df
Compare
@george-angel , can you make a new release 1.5.4? |
The package needs to be updated to resolve the bug #389 and #96
The problem comes from a parsing error. In the package protobufjs, the bug has already been fixed: protobufjs/protobuf.js#1256