New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BrPage Component in Bloomreach React SDK #32

Open

cosieLq wants to merge 3 commits into bloomreach:main from cosieLq:feature/refactor-brpage

cosieLq commented Mar 6, 2024

Hi,

This PR tries to refactor the code for BrPage in @bloomreach/react-sdk with the following aims:

BrPage becomes a function component in line with the recommendation from React
The code becomes a bit simpler and easier to maintain, for instance avoiding calling destroy and re-sync if only the configuration in props has changed, but page in props hasn't changed
May be a starting point for further refactoring of BrPage so that it better fits the development in React...

This is my first commit to this repo, and comments are very welcome! ☺️

cosieLq added 3 commits

March 6, 2024 12:40


          Refactor BrPage Component

9378a47


          Fix unit tests

5a69613


          Disable eslint rules for some lines

393b61c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment