Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -fcoroutines-ts flag when clang (>= 16.0) is used #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smtrfnv
Copy link
Contributor

@smtrfnv smtrfnv commented Mar 2, 2024

  • -fcoroutines-ts was deprecated in clang 16.0
  • -fcoroutines-ts was removed in clang 17.0
  • clang 16, clang 17 and clang 18 do not like -fcoroutines flag either

Some examples of errorsI encountered when trying to use either -fcoroutines-ts or -fcoroutines flag with modern clang:

  • CLANG-16, CPP20 DBG

clang-16: error: the '-fcoroutines-ts' flag is deprecated and it will be removed in Clang 17; use '-std=c++20' or higher to use standard C++ coroutines instead [-Werror,-Wdeprecated-experimental-coroutine]

  • CLANG-18, CPP03 DBG

clang++clang++: : warning: argument unused during compilation: '-fcoroutines' [-Wunused-command-line-argument]

  • CLANG-18, CPP20 DBG

clang++clang++: : error: error: argument unused during compilation: '-fcoroutines' [-Werror,-Wunused-command-line-argument]

  • CLANG-18, CPP20 OPT

clang++: error: argument unused during compilation: '-fcoroutines' [-Werror,-Wunused-command-line-argument]

@smtrfnv smtrfnv marked this pull request as draft March 2, 2024 16:00
@smtrfnv smtrfnv force-pushed the replace_fcoroutines-ts_flag branch from d4be3d6 to 2f0b739 Compare March 2, 2024 18:31
@smtrfnv smtrfnv marked this pull request as ready for review March 2, 2024 18:33
@smtrfnv smtrfnv marked this pull request as draft May 20, 2024 18:42
@smtrfnv smtrfnv force-pushed the replace_fcoroutines-ts_flag branch from d389d44 to 0668876 Compare May 21, 2024 07:33
@smtrfnv smtrfnv force-pushed the replace_fcoroutines-ts_flag branch from 0668876 to ac7bf00 Compare May 21, 2024 07:39
@smtrfnv smtrfnv changed the title replace -fcoroutines-ts flag with -fcoroutines for clang Remove -fcoroutines-ts flag when clang (>= 16.0) is used May 21, 2024
@smtrfnv smtrfnv marked this pull request as ready for review May 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant