Make unit tests build on Ubuntu 20 #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Louis Leroy <jleroy9@bloomberg.net>
Signed-off-by: Jean-Louis Leroy <jleroy9@bloomberg.net>
jll63
changed the title
hallfox
reviewed
Aug 17, 2023
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | ||
| -DFLEX_ROOT=/usr/lib/x86_64-linux-gnu" | ||
| -DFLEX_ROOT=/usr/lib/x86_64-linux-gnu \ | ||
| -Dlibbenchmark=/usr/lib/x86_64-linux-gnu/libbenchmark.so" |
There was a problem hiding this comment.
I don't know how I feel about putting this workaround in this script. Can we flags this as either something that we set as a purely Ubuntu 20 workaround or instead grab it from find_package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Unit tests don't build on Ubuntu 20.
Testing performed
Build and run the tests.
Additional context
Problem was caused by an incorrect
benchmark.pcfile. Applied a work around that works on Ubuntu 22 as well.