Fix -Wconversion and other warnings #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
678098
requested changes
May 13, 2024
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
678098
requested changes
May 15, 2024
| float messageCount = ceil(k_NUM_RECORDS / 3.0); | ||
| float outstandingRatio = float(partiallyConfirmedGUIDS.size() + 1) / | ||
| messageCount * 100.0; | ||
| const size_t messageCount = k_NUM_RECORDS / 3 + 1; |
There was a problem hiding this comment.
Here, if k_NUM_RECORDS == 3:
the previous code will have messageCount == 1.0f
the updated code will have messageCount == 2
This should help
Suggested change
| const size_t messageCount = k_NUM_RECORDS / 3 + 1; | |
| const size_t messageCount = (k_NUM_RECORDS + 2) / 3; |
There was a problem hiding this comment.
Nice suggestion! The test won't break if we change k_NUM_RECORDS in the future
| 100.0; | ||
| const size_t messageCount = k_NUM_RECORDS / 3; | ||
| const float outstandingRatio = float(outstandingGUIDS.size()) / | ||
| float(messageCount) * 100.0f; |
There was a problem hiding this comment.
Might be good to use C++ static_casts here and below, not the C-style casts. We can do it in a separate PR if we don't want to increase the scope of this one
| #else | ||
| const size_t k_NUM_ELEMENTS = 1000 * 1000; // 1M | ||
| const int k_NUM_ELEMENTS = 1000 * 1000; // 1M |
There was a problem hiding this comment.
Suggested change
| const int k_NUM_ELEMENTS = 1000 * 1000; // 1M | |
| const int k_NUM_ELEMENTS = 1000 * 1000; // 1M |
There was a problem hiding this comment.
Yeah, this formatting looks strange, but that's exactly what clang-format did. CI fails otherwise, check this log
678098
assigned alexander-e1off and waldgange and unassigned 678098 and alexander-e1off
Signed-off-by: Anton Pryakhin <apryakhin1@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.