Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigureStream unconditionally #224

Closed
wants to merge 1 commit into from

Conversation

dorjesinpo
Copy link
Collaborator

Retire ConfigureQueueStream
SDK sends ConfigureStream unconditionally. This must be in accord with broker's MessageProperties V2 and configureStream configurations.

@dorjesinpo dorjesinpo added the enhancement New feature or request label Mar 21, 2024
@dorjesinpo dorjesinpo requested a review from a team as a code owner March 21, 2024 21:13
kaikulimu
kaikulimu previously approved these changes Mar 22, 2024
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this the change we need to make a subscription-aware libbmq release?

Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge it yet. Please wait for libbmq promotion to fix libmwc backward compatibility issues first.

@dorjesinpo
Copy link
Collaborator Author

replacing with #301

@dorjesinpo dorjesinpo closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants