Add clang format control for cpp11 features #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
force-pushed
the
cpp03-format-fix
branch
from
f10d473
to
93bf972
Compare
pniedzielski
requested changes
Jan 9, 2024
|
This is odd, locally I'm formatting these files and it changes nothing. Perhaps this is a clang-format version difference issue. Let me try running with clang-format-14 locally. |
678098
reviewed
Jan 9, 2024
| #undef COMPILING_MWCEX_BINDUTIL_H | ||
| # define COMPILING_MWCEX_BINDUTIL_H | ||
| # include <mwcex_bindutil_cpp03.h> | ||
| # undef COMPILING_MWCEX_BINDUTIL_H |
There was a problem hiding this comment.
This is sim_cpp11_features.pl's output
hallfox
force-pushed
the
cpp03-format-fix
branch
3 times, most recently
from
3e591fc
to
afd236c
Compare
Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net> Regenerate cpp03 files Update clang-format version in gh actions Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
hallfox
force-pushed
the
cpp03-format-fix
branch
from
afd236c
to
36dc232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes minimize the amount of changes coming from the files supporting a simulating C++11, eliminating all discrepancies except the license header. Future versions of sim_cpp11_features.pl should address this issue.