Inline Put, Push, Ack, Confirm #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
force-pushed
the
inline-push-ack
branch
3 times, most recently
from
6d2f55e
to
e21c4cd
Compare
|
Hi @dorjesinpo, looking |
678098
requested changes
Jan 8, 2024
Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
dorjesinpo
force-pushed
the
inline-push-ack
branch
from
e21c4cd
to
51bc378
Compare
dorjesinpo
commented
Jan 10, 2024
| @@ -369,6 +345,8 @@ void ClusterProxy::onActiveNodeUp(mqbnet::ClusterNode* activeNode) | |||
| return; // RETURN | |||
| } | |||
|
|
|||
| d_activeNode_p = activeNode; | |||
There was a problem hiding this comment.
Because d_activeNode_p is (half) protected by d_gateActiveNode - it is safe to use if mqbc::GateKeeper::Status(d_gateActiveNode).isOpen()
d_activeNodeManager.activeNode() does not provide such guarantee.
I agree, this calls for refactoring, not in this PR, perhaps
| pinfo.primaryLeaseId()); | ||
| } | ||
| } | ||
|
|
||
| // TODO: this code assumes that it is safe to send PUTs and CONFIRMS at | ||
| // this point if the status is E_ACTIVE or close the gate otherwise. | ||
| // May need to open the gate later/close earlier by a separate call. |
There was a problem hiding this comment.
This mimics the existing functionality. If the status is E_ACTIVE we call Channel::writeConfirm/writePut.
If the channel fails to write, confirm may get lost resulting in duplicate PUSH, and PUT will be retransmitted.
|
@dorjesinpo thank you for fixes, added some comments in discussions and reassigned. You can assign this to @quarter-note later |
Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages that have fixed destination (such as PUSH/ACK/Relay PUT/Relay CONFIRM) do not have to go on Cluster thread - it is a bottleneck.
Instead, messages can go directly to mqbnet::Channel which enqueues them in thread-safe manner.
This needs synchronization based on AtomicGate which allows thread-safe, efficient checking of the cluster status and thread-safe opening/closing and draining.
PUSH and ACK require statistics update which we move from Cluster to Queue. For this reason the opening queue context (OpenQueueConfirmationCookie) conveys statistics from Queue to Cluster