BlazingMQ C SDK Initial Pull Request #169

Simon-Sandrew · 2023-12-08T20:20:10Z

Initial PR for the C SDK.
Requesting review on everything in the z_bmq folder.

kaikulimu · 2023-12-14T00:57:35Z

@Simon-Sandrew Thanks for the PR! Two quick things:

Could you run clang-format over your changes? The CI Formatting Check check is failing.
Could you sign off your commits following https://github.com/bloomberg/blazingmq/blob/main/CONTRIBUTING.md#dco-check? The CI DCO check is failing.

kaikulimu · 2023-12-14T01:00:46Z

@hallfox Would you like to take a look at whether the basic code layout and directory structure make sense? And then I can take a more-depth look.

hallfox · 2023-12-14T16:44:25Z

Addresses #114

hallfox · 2023-12-19T19:52:22Z

src/groups/CMakeLists.txt

@@ -4,3 +4,4 @@
 add_subdirectory(mwc)
 add_subdirectory(bmq)
 add_subdirectory(mqb)
+add_subdirectory(z_bmq)


Internal standards would place this package in src/wrappers/z_bmq.

(There's no way you could have known this nor do I recall mentioning it in our previous communication so no worries, let's just move it there before we make any bigger changes.)

hallfox · 2023-12-19T19:53:23Z

src/groups/z_bmq/doc/z_bmq.txt

@@ -0,0 +1,63 @@
+ bmq.txt


This whole document needs to be updated to reflect the purpose and modules available in the C wrapper.

hallfox · 2023-12-19T19:54:18Z

src/groups/z_bmq/z_bmq_demo/demo.c

@@ -0,0 +1,83 @@
+#include <z_bmqa_session.h>


This file should probably live in the examples directory

hallfox · 2023-12-19T19:55:55Z

src/groups/z_bmq/z_bmqa/demo.h

@@ -0,0 +1,104 @@
+#include <z_bmqa_session.h>


Is this file supposed to be here?

hallfox · 2023-12-19T19:56:39Z

src/groups/z_bmq/z_bmqa/z_bmqa_confirmeventbuilder.cpp

+#include <bmqa_confirmeventbuilder.h>
+
+
+int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder const** builder_obj) {


Suggested change

int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder const** builder_obj) {

int z_bmqa_ConfirmEventBuilder__delete(const z_bmqa_ConfirmEventBuilder** builder_obj) {

This is just part of the BDE style guide

hallfox · 2023-12-19T20:01:45Z

src/groups/z_bmq/z_bmqa/z_bmqa_confirmeventbuilder.cpp

+    const bmqa::ConfirmEventBuilder* builder_p = reinterpret_cast<const bmqa::ConfirmEventBuilder*>(*builder_obj);
+    delete builder_p;


In general we like to use these BSLS_ASSERT macros to help check the contract of functions. In this case, we should note in the docstring for this function where undefined behavior exists, and insert these assert macros to check against it.

Suggested change

const bmqa::ConfirmEventBuilder* builder_p = reinterpret_cast<const bmqa::ConfirmEventBuilder*>(*builder_obj);

delete builder_p;

BSLS_ASSERT(builder_obj != NULL);

const bmqa::ConfirmEventBuilder* builder_p = reinterpret_cast<const bmqa::ConfirmEventBuilder*>(*builder_obj);

delete builder_p;

hallfox · 2023-12-19T20:02:09Z

src/groups/z_bmq/z_bmqa/z_bmqa_confirmeventbuilder.h

+int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder** builder_obj);
+
+int z_bmqa_ConfirmEventBuilder__create(z_bmqa_ConfirmEventBuilder** builder_obj);
+
+int z_bmqa_ConfirmEventBuilder__addMessageConfirmation(z_bmqa_ConfirmEventBuilder* builder_obj,
+                                                       const z_bmqa_Message* message);
+
+int z_bmqa_ConfirmEventBuilder__addMessageConfirmationWithCookie(z_bmqa_ConfirmEventBuilder* builder_obj,
+                                                                 const z_bmqa_MessageConfirmationCookie* cookie);
+
+int z_bmqa_ConfirmEventBuilder__reset(z_bmqa_ConfirmEventBuilder* builder_obj);
+
+int z_bmqa_ConfirmEventBuilder__messageCount(const z_bmqa_ConfirmEventBuilder* builder_obj);
+
+int z_bmqa_ConfirmEventBuilder__blob(const z_bmqa_ConfirmEventBuilder* builder_obj, z_bmqt_Blob const** blob_obj);


These all need docstrings

hallfox · 2023-12-19T20:02:52Z

src/groups/z_bmq/z_bmqa/z_bmqa_confirmeventbuilder.h

+typedef struct z_bmqa_ConfirmEventBuilder z_bmqa_ConfirmEventBuilder;
+typedef struct z_bmqa_MessageConfirmationCookie z_bmqa_MessageConfirmationCookie;
+
+int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder** builder_obj);


I don't necessarily agree that doing the double pointer trick for destruction is the way we should go, let me think about it.

hallfox · 2023-12-19T20:06:43Z

src/groups/z_bmq/z_bmqa/z_bmqa_session.t.cpp

+//                                    TESTS
+// ----------------------------------------------------------------------------
+
+static void test1_session()


We're going to need more basic tests for each one of the APIs that we create here.

…flicts

…scriptionExpression, and also finished functions in QueueOptions that use Subscription objects

…tyling

…flicts

…gorithmType

C wrapper

Address comments from PR

* Updated toString methods, updated correlationId, and added tests for correlationId * Fixed mem leaks in producer and consumer * Moved c_wrapper tutorial * Added propertytype and move includes to be withing the extern C declaration * Fixed messageproperties.h --------- Co-authored-by: Jonathan Adotey <jon@2603-7081-50f0-6010-0000-0000-0000-1a75.res6.spectrum.com> Co-authored-by: Jonathan Adotey <jon@sage-lab-lower-286.dynamic2.rpi.edu>

* Add files via upload * Add files via upload * changes * Delete src/docstring_replace.py * Delete src/function_comments.py --------- Co-authored-by: Fatih Orhan <56280631+FatihOrhan0@users.noreply.github.com>

* Made basic test for z_bmqa_sessionevent, not tested yet * Message Event Builder Test * Worked on QueueId test * Wrote Doxygen documentation for each function in message.h

* rewrote setProperty functions for char, short, int32, int64, string, and binary, including headers * done with some headers * did get headers for bool,char,short,int32,int64 * did headers for getPropertyAsString & Binary, then did the getProperty(Or) headers until String, still have to do binary. did implementations for all these headers in C as well * did getPropertyAsBinaryOr, assuming client provides size * learned underlying rep of bsl string - simplified these functions * messageproperties done I believe, waiting on review * changes to roperty * examples

* Add files via upload * Add files via upload * changes * Delete src/docstring_replace.py * Delete src/function_comments.py * final comments * final --------- Co-authored-by: Fatih Orhan <56280631+FatihOrhan0@users.noreply.github.com>

kaikulimu · 2024-03-20T19:03:07Z

src/applications/bmqbrkr/etc/etc

@@ -0,0 +1 @@
+/Users/aaryaman/Documents/bmq/blazingmq/src/applications/bmqbrkr/etc


Personal paths should not be committed.

hallfox · 2024-03-20T19:03:43Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

@@ -0,0 +1,63 @@
+ z_bmq.txt


This description needs updating

hallfox · 2024-03-20T19:06:58Z

src/applications/bmqbrkr/etc/etc

@@ -0,0 +1 @@
+/Users/aaryaman/Documents/bmq/blazingmq/src/applications/bmqbrkr/etc


This will need to be removed

hallfox · 2024-03-20T19:17:35Z

src/groups/CMakeLists.txt

@@ -4,3 +4,4 @@
 add_subdirectory(mwc)
 add_subdirectory(bmq)
 add_subdirectory(mqb)
+add_subdirectory(wrappers/z_bmq)


The wrappers directory should be below src

hallfox · 2024-03-20T19:18:15Z

src/groups/wrappers/z_bmq/CMakeLists.txt

+# Add the libbmq group library only installing the public headers
+add_library(z_bmq)
+
+target_compile_definitions(z_bmq PRIVATE "MWC_INTERNAL_USAGE")


Suggested change

target_compile_definitions(z_bmq PRIVATE "MWC_INTERNAL_USAGE")

I don't think this library should need internal usage of mwc to work

hallfox · 2024-03-20T19:18:23Z

src/groups/wrappers/z_bmq/z-bmq.pc

@@ -0,0 +1,10 @@
+prefix=/usr/local


This file shouldn't be necessary

hallfox · 2024-03-20T20:38:44Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.t.cpp

+static void test1_session()
+{
+    // run_c_producer();
+}


hallfox · 2024-03-20T20:59:27Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.cpp

+}
+
+int z_bmqa_Session__createAsync(z_bmqa_Session**             session_obj,
+                                z_bmqa_SessionEventHandler*  eventHandler,


I think instead of being passed this custom SessionEventHandler, it would be better to do something like this:

// in z_bmqa_session.h typedef struct z_bmqa_SessionEventHandlers { z_bmqa_OnSessionEventCb onSessionEvent, z_bmqa_OnMessageEventCb onMessageEvent }; int z_bmqa_Session__createAsync(z_bmqa_Session** session, z_bmqa_SessionEventHandlers eventHandlers, void* context, const z_bmqt_SessionOptions* options);

// in z_bmqa_session.cpp int z_bmqa_Session__createAsync(z_bmqa_Session** session, z_bmqa_SessionEventHandlers eventHandlers, const z_bmqt_SessionOptions* options) { // ... eventHandler_mp = bslma::ManagedPtr<CustomEventHandler>(eventHandlers, context); session_p = new bmqa::Session(eventHandler_mp, *options_p); // ... } class CustomEventHandler: public bmqa::SessionEventHandler { private: z_bmqa_EventHandlers d_eventHandlers; void* d_context; public: CustomEventHandler(z_bmqa_EventHandlers eventHandlers, void* context): d_eventHandlers(eventHandlers), d_context(context) {} void onSessionEvent(const SessionEvent& event) BSLS_KEYWORD_OVERRIDE { z_bmqa_SessionEvent* event_p = reinterpret_cast<...>(event); (*d_eventHandlers.onSessionEvent)(event_p, d_context); } void onMessageEvent(const MessageEvent& event) BSLS_KEYWORD_OVERRIDE { // likewise... } };

hallfox · 2024-03-20T21:00:54Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.cpp

+    bmqa::QueueId* queueId_p = reinterpret_cast<bmqa::QueueId*>(queueId);
+    bmqa::CloseQueueStatus* status_p = new bmqa::CloseQueueStatus();
+
+    // Implement timeout


hallfox · 2024-03-20T21:11:42Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.t.cpp

+static void test1_session()
+{
+    // run_c_producer();
+}
+


hallfox · 2024-03-20T22:31:32Z

src/groups/wrappers/z_bmq/z_bmqt/z_bmqt_compressionalgorithmtype.h

+
+#include <stdbool.h>
+
+struct z_bmqt_CompressionAlgorithmType {


This uses C++ constructs, it should probably just be rexposed as an enum:

typedef enum { z_bmqt_CompresssionAlgorithmType__e_UKNOWN = -1, ... } z_bmqt_CompressionAlgorithmType;

Unfortunately, there's no real easy way to define this enum in terms of its C++ equivalent, as that would require accessing a C++ symbol in the header file. There are probably some tricks, but I don't think it would be worth it. What we can do is add some checks at compile time that our C header definitions match the C++ definitions with a static assert:

// in z_bmqt_compressionalgorithmtype.cpp #include <z_bmqt_compressionalgorithmtype.h> #include <bmqt_compressionalgorithmtype.h> #include <bslmf_assert.h> BSLMF_ASSERT(z_bmqt_CompressionAlgorithmType__e_UNKNOWN == bmqt::CompressionAlgorithmType::e_UNKNOWN); ...

marvin-hansen · 2024-03-22T13:45:09Z

Out of interest, is there an ETA for getting an initial C SDK merged? I’m considering experimenting with Rust bindings and a C / FFI interface would be awesome.

kaikulimu · 2024-03-22T14:36:24Z

Out of interest, is there an ETA for getting an initial C SDK merged? I’m considering experimenting with Rust bindings and a C / FFI interface would be awesome.

Hi Marvin, thanks for the interest! The ETA to merge this PR is around a month. Also, we have been experimenting with Rust bindings over this C API as well. We can find some time to discuss our ideas.

marvin-hansen · 2024-03-22T15:10:39Z

Excellent. Around a month sounds good to me. Background is, I just started a multi exchange data streaming project in Rust and, obviously, BlazingMQ would be an ideal candidate as low latency messaging middleware. Let’s discuss and exchange ideas. Please send me a message using the contact form below and we find sone time. https://emet-labs.com/contact/

…

On Fri, Mar 22, 2024 at 10:36 PM Yuan Jing Vincent Yan < ***@***.***> wrote: Out of interest, is there an ETA for getting an initial C SDK merged? I’m considering experimenting with Rust bindings and a C / FFI interface would be awesome. Hi Marvin, thanks for the interest! The ETA to merge this PR is around a month. Also, we have been experimenting with Rust bindings over this C API as well. We can find some time to discuss our ideas. — Reply to this email directly, view it on GitHub <#169 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFYR7XHNUQLY2T45IDU5HRDYZQ6X7AVCNFSM6AAAAABANEW2DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGI2DAOJZGA> . You are receiving this because you commented.Message ID: ***@***.***>

kaikulimu

I have reviewed 23 out of 77 files (alphabetically from .gitignore to z_bmqa_message.h). In addition to the comments, please fix the build and formatting errors in the CI.

kaikulimu · 2024-03-22T19:33:21Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

@@ -0,0 +1,63 @@
+ z_bmq.txt
+
+@PURPOSE: Public SDK API for the BlazingMQ framework.


Suggested change

@PURPOSE: Public SDK API for the BlazingMQ framework.

@PURPOSE: Public C SDK API for the BlazingMQ framework.

kaikulimu · 2024-03-22T19:34:09Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

+
+@MNEMONIC: BlazingMQ (bmq)
+
+@DESCRIPTION: BlazingmQ (package group 'bmq') is a message-queue


bmq -> z_bmq

kaikulimu · 2024-03-22T19:34:28Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

+ The 'bmqa' and 'bmqt' packages contain all components that constitute the
+ public API for BlazingmQ users to use.  A client should only use the
+ components in these packages, and should not use any other package under the
+ 'bmq' package group since they are implementation components that may change


bmq -> z_bmq

kaikulimu · 2024-03-22T19:34:53Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

+@DESCRIPTION: BlazingmQ (package group 'bmq') is a message-queue
+ framework allowing application developers to use reliable distributed queues.
+
+ The 'bmqa' and 'bmqt' packages contain all components that constitute the


bmqa -> z_bmqa
bmqt -> z_bmqt

kaikulimu · 2024-03-22T19:37:15Z

src/groups/wrappers/z_bmq/doc/z_bmq.txt

+ 'bmq' package group since they are implementation components that may change
+ at any time.
+
+/Hierarchical Synopsis


Please update the rest of the document to reflect z_bmq accurately as well

kaikulimu · 2024-03-26T21:34:17Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_event.h

+
+typedef struct z_bmqa_Event z_bmqa_Event;
+
+int z_bmqa_Event__create(z_bmqa_Event** event_obj);


Unimplemented and undocumented function...

kaikulimu · 2024-03-26T21:34:23Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_event.h

+
+int z_bmqa_Event__create(z_bmqa_Event** event_obj);
+
+int z_bmqa_Event__SessionEvent(z_bmqa_Event* event_obj);


Unimplemented and undocumented function...

kaikulimu · 2024-03-26T21:59:24Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_message.cpp

+    bmqa::Message* other_p = new bmqa::Message();
+    *other_p               = message_p->clone();


message_p->clone() on the next line already returns a bmqa::Message. There is no need to call new bmqa::Message(); here. Can simplify as:

Suggested change

bmqa::Message* other_p = new bmqa::Message();

*other_p = message_p->clone();

bmqa::Message* other_p = message_p->clone();

Also, bmqa::Message::clone() is allocator-aware. Not sure if we should worry about allocator support here though.

kaikulimu · 2024-03-26T22:15:21Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_message.cpp

+    bsl::string data_str         = ss.str();
+    *buffer                      = new char[data_str.length() + 1];
+    (*buffer)[data_str.length()] = '\0';
+    strcpy(*buffer, data_str.c_str());


While the transformation via HexDumper is technically correct, it's got a few problems:

I'm pretty sure there is an unnecessary copy with the stringstream::str call

strcpy is an unsafe operation and should be avoided if possible

The buffer should probably be zero initialized

My preference would be to use bdlbb::BlobUtil::copy(char *dstBuffer, const Blob& srcBlob, int position, int length).

Please add a unit test to ensure that z_bmqa_Message__getData() works as intended.

kaikulimu · 2024-03-26T22:15:45Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_message.cpp

+    return message_p->ackStatus();
+}
+
+// Add once we figure out how to handle Blobs in C


Please remove this comment section

kaikulimu

Haven't gone through all files yet. But here are more comments.

As a general note, we should have unit tests for all non-trivial and error-prone functions.

kaikulimu · 2024-04-09T18:41:31Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageevent.cpp

+#include <bmqa_messageevent.h>
+#include <bsl_sstream.h>
+#include <bsl_string.h>
+#include <z_bmqa_messageevent.h>


Move to first line of include

I'm pretty sure this means move #include <z_bmqa_messageevent.h> but not sure

kaikulimu · 2024-04-09T18:52:39Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageevent.cpp

+    bsl::string out_str = ss.str();
+
+    *out = new char[out_str.length() + 1];
+    strcpy(*out, out_str.c_str());


strcpy is an unsafe operation and should be avoided if possible. strncpy is a safer alternative which specifies the number of bytes to be copied.

Also, please add a unit test for this toString() method.

kaikulimu · 2024-04-09T21:23:01Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageproperties.cpp

+    bmqa::MessageProperties* properties_p = 
+        reinterpret_cast<bmqa::MessageProperties*>(properties_obj); 
+
+    //can I just use Enum like this? 


Please finish implementation

kaikulimu · 2024-04-09T21:40:34Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageproperties.cpp

+    return properties_p->setPropertyAsInt64(name_str,value); 
+}
+
+//needs rigorous testing to see if value conversion to bsl::string is needed, or we use the char* value 


My guess is you do need a conversion to bsl::string. But adding a test is always a good idea!

kaikulimu · 2024-04-09T21:45:36Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageproperties.cpp

+    return properties_p->getPropertyAsInt64(name_str);
+}
+
+//docstring needs to include freeing cStr


The return value is a reference to propertyAsBSLString, which is a reference to the MessageProperties. Therefore, you should not free the returning c_str directly.

kaikulimu · 2024-04-09T21:57:55Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_messageproperties.h

+bool z_bmqa_MessageProperties__remove(
+    z_bmqa_MessageProperties* properties_obj, 
+    const char* name, 
+    Enum *buffer);


I am unconfident that passing Enum *buffer would work properly. Could you please add a test case for this?

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_queueid.t.cpp

kaikulimu · 2024-04-09T22:07:41Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_queueid.t.cpp

+//                                 MAIN PROGRAM
+// ----------------------------------------------------------------------------
+
+int main(int argc, char* argv[])


Great job! Very nice tests haha

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_sessionevent.t.cpp

kaikulimu · 2024-04-09T22:09:58Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_sessionevent.t.cpp

+    mwctst::TestHelper::printTestName("BREATHING TEST");
+
+    z_bmqa_SessionEvent * obj;
+    z_bmqa_SessionEvent__create(&obj);


Since you tested creation, you might as well test z_bmqa_SessionEvent__delete.

kaikulimu

Went through the remaining files. Have more comments

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.h

kaikulimu · 2024-04-10T19:09:59Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.cpp

+    return 0;
+}
+
+// int z_bmqa_Session__confirmMessage(z_bmqa_Session*       session_obj,


To be implemented

kaikulimu · 2024-04-10T19:10:06Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.cpp

+//     reinterpret_cast<bmqa::Session*>(session_obj);
+// }
+
+// int z_bmqa_Session__confirmMessageWithCookie(


To be implemented

kaikulimu · 2024-04-10T19:10:15Z

src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.cpp

+    return 0;
+}
+
+// int z_bmqa_Session__getQueueIdWithUri(z_bmqa_Session* session_obj,


To be implemented

src/groups/wrappers/z_bmq/z_bmqt/z_bmqt_messageguid.cpp

src/groups/wrappers/z_bmq/z_bmqt/z_bmqt_propertytype.cpp

src/groups/wrappers/z_bmq/z_bmqt/z_bmqt_sessioneventtype.h

src/groups/wrappers/z_bmq/z_bmqt/z_bmqt_subscription.cpp

Co-authored-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> Signed-off-by: Simon Sandrew <64385077+Simon-Sandrew@users.noreply.github.com>

kaikulimu · 2024-04-17T16:39:02Z

@pniedzielski Adding you as a reviewer

* Add files via upload * Add files via upload * changes * Delete src/docstring_replace.py * Delete src/function_comments.py * final comments * final * deleted external files * towards future commits * pr feedbakc --------- Co-authored-by: Fatih Orhan <56280631+FatihOrhan0@users.noreply.github.com>

Simon-Sandrew requested a review from a team as a code owner December 8, 2023 20:20

hallfox reviewed Dec 19, 2023

View reviewed changes

Jonathan Adotey and others added 25 commits January 24, 2024 14:23

Initial code

3a34d45

Added z_bmq to build configs

27ce71d

Made progress on CorrelatonId and QueueId

5f79d23

Finished QueueOptions, and changed constructors to avoid C naming con…

9f2ff58

…flicts

Fixed minor errors

f662467

Added wrapper functions for Subscription, SubscriptionHandle, and Sub…

9190f2a

…scriptionExpression, and also finished functions in QueueOptions that use Subscription objects

Started Session implementation

12fc043

Added headers for z_bmqa_Session

031c034

test

ccfa5e6

Initial implementation of z_bmqa_MessageEventBuilder

0efcb02

Initial implementation of z_bmqa_ConfirmEventBuilder

c208895

producer bare minimum

9459753

demo files + minor fixes

63b54cf

More changes

1849c31

Got C producer working, will clean later

2ee34f7

fixed mem leak and switched '_ptr' to '_p' to comply with bloomberg s…

e4e2c92

…tyling

Progress

d21c924

Add CMakeLists.txt for c_wrapper

0666ce9

Progress(2)

a69e978

Add cmake edit

5a54f03

Initial code

b079bf7

Added z_bmq to build configs

7011a61

Made progress on CorrelatonId and QueueId

572e38c

Finished QueueOptions, and changed constructors to avoid C naming con…

8e188c3

…flicts

Fixed minor errors

232222d

Jonathan Adotey and others added 18 commits January 26, 2024 13:02

Added tests for SessionEventType, MessageEventType, and CompressionAl…

7f492a6

…gorithmType

Merge pull request #2 from jonathanadotey77/c_wrapper

1366de1

C wrapper

Ran formatter and deleted demo.h

d7c657d

test

eb918c7

Moved z_bmq into wrappers/z_bmq

3e7c907

Removed z_bmq_demo

a6d0ffc

Addressed some comments from the december PR

a234e0c

Formatted z_bmqa_sessionevent.cpp

4962eca

Merge pull request #5 from jonathanadotey77/main

982e168

Address comments from PR

Fixing the buidl

5a7cb36

Made basic test for z_bmqa_sessionevent, not tested yet (#8)

5325161

Merge branch 'bloomberg:main' into main

9a02d32

Fork (#10)

a0e317b

* Add files via upload * Add files via upload * changes * Delete src/docstring_replace.py * Delete src/function_comments.py --------- Co-authored-by: Fatih Orhan <56280631+FatihOrhan0@users.noreply.github.com>

Kaan Changes (#11)

31aabe5

* Made basic test for z_bmqa_sessionevent, not tested yet * Message Event Builder Test * Worked on QueueId test * Wrote Doxygen documentation for each function in message.h

comments (#13)

7578194

* Add files via upload * Add files via upload * changes * Delete src/docstring_replace.py * Delete src/function_comments.py * final comments * final --------- Co-authored-by: Fatih Orhan <56280631+FatihOrhan0@users.noreply.github.com>

Merge branch 'bloomberg:main' into main

2a0c76c

kaikulimu reviewed Mar 20, 2024

View reviewed changes

hallfox reviewed Mar 20, 2024

View reviewed changes

kaikulimu requested changes Mar 26, 2024

View reviewed changes

kaikulimu reviewed Apr 9, 2024

View reviewed changes

kaikulimu reviewed Apr 10, 2024

View reviewed changes

Update src/groups/wrappers/z_bmq/z_bmqa/z_bmqa_session.h

e5639c0

Co-authored-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> Signed-off-by: Simon Sandrew <64385077+Simon-Sandrew@users.noreply.github.com>

marvin-hansen mentioned this pull request May 5, 2024

Rust SDK #272

Open

1 task

		#include <bmqa_confirmeventbuilder.h>


		int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder const** builder_obj) {

	int z_bmqa_ConfirmEventBuilder__delete(z_bmqa_ConfirmEventBuilder const** builder_obj) {
	int z_bmqa_ConfirmEventBuilder__delete(const z_bmqa_ConfirmEventBuilder** builder_obj) {

		const bmqa::ConfirmEventBuilder* builder_p = reinterpret_cast<const bmqa::ConfirmEventBuilder>(builder_obj);
		delete builder_p;

		@@ -0,0 +1 @@
		/Users/aaryaman/Documents/bmq/blazingmq/src/applications/bmqbrkr/etc


		#include <stdbool.h>

		struct z_bmqt_CompressionAlgorithmType {

		@@ -0,0 +1,63 @@
		z_bmq.txt

		@PURPOSE: Public SDK API for the BlazingMQ framework.

	@PURPOSE: Public SDK API for the BlazingMQ framework.
	@PURPOSE: Public C SDK API for the BlazingMQ framework.


		@MNEMONIC: BlazingMQ (bmq)

		@DESCRIPTION: BlazingmQ (package group 'bmq') is a message-queue


		typedef struct z_bmqa_Event z_bmqa_Event;

		int z_bmqa_Event__create(z_bmqa_Event** event_obj);


		int z_bmqa_Event__create(z_bmqa_Event** event_obj);

		int z_bmqa_Event__SessionEvent(z_bmqa_Event* event_obj);

		bmqa::Message* other_p = new bmqa::Message();
		*other_p = message_p->clone();

	bmqa::Message* other_p = new bmqa::Message();
	*other_p = message_p->clone();
	bmqa::Message* other_p = message_p->clone();

BlazingMQ C SDK Initial Pull Request #169

Are you sure you want to change the base?

BlazingMQ C SDK Initial Pull Request #169

Conversation

Simon-Sandrew commented Dec 8, 2023

kaikulimu commented Dec 14, 2023

kaikulimu commented Dec 14, 2023

hallfox commented Dec 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marvin-hansen commented Mar 22, 2024

kaikulimu commented Mar 22, 2024

marvin-hansen commented Mar 22, 2024 via email

kaikulimu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaikulimu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaikulimu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaikulimu commented Apr 17, 2024