-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Advanced Filters #9769
Open
sl1depengwyn
wants to merge
12
commits into
master
Choose a base branch
from
mf-advanced-filters
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Advanced Filters #9769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
3 times, most recently
from
April 1, 2024 13:27
5a977bc
to
c635744
Compare
sl1depengwyn
requested review from
vbaranov,
k1rill-fedoseev,
nikitosing,
varasev and
Qwerty5Uiop
April 1, 2024 13:29
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
2 times, most recently
from
April 4, 2024 15:44
84117ef
to
978d912
Compare
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
from
April 9, 2024 13:04
c408831
to
596facc
Compare
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
from
April 30, 2024 19:21
ecf092d
to
7f051b4
Compare
vbaranov
reviewed
May 1, 2024
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
from
May 7, 2024 00:30
718eda8
to
5d2b868
Compare
vbaranov
approved these changes
May 13, 2024
query = | ||
from( | ||
contract_method in __MODULE__, | ||
distinct: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to select distinct, if the resulted number is limited by one row?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't, fixed in 8fd1cd8
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
2 times, most recently
from
May 27, 2024 12:40
e0104d7
to
8fd1cd8
Compare
Add search_params to response Add limit to tokens endpoint Add fee in api response Add exclusion/inclusion of from/to addresses Remove raw_input from api response
sl1depengwyn
force-pushed
the
mf-advanced-filters
branch
from
May 28, 2024 10:37
8fd1cd8
to
32e1ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7794
Close #9034
Changelog
Add
api/v2/advanced-filters/methods
endpoint:Example of response:
At the moment it returns static most popular methods, to be improved as a separate task: Add popular methods endpoint for advanced filters #9773
Add
api/v2/advanced-filters
endpointPostman request: https://www.postman.com/blockscout/workspace/api-v2/request/19099777-b134d11e-dda0-4adc-a4cc-dfbe4e001f23
Checklist for your Pull Request (PR)
master
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.