Enable URL-encoded chars support in DB username #9588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl1depengwyn
force-pushed
the
url-encoded-username
branch
from
655cb20
to
8ce1f18
Compare
sl1depengwyn
force-pushed
the
url-encoded-username
branch
from
8ce1f18
to
a42164a
Compare
vbaranov
reviewed
Mar 12, 2024
| @@ -56,9 +55,9 @@ defmodule Explorer.Repo.ConfigHelper do | |||
|
|
|||
| # sobelow_skip ["DOS.StringToAtom"] | |||
| defp extract_parameters(database_url) do | |||
| ~r/\w*:\/\/(?<username>[a-zA-Z0-9_-]*):(?<password>[a-zA-Z0-9-*#!%^&$_.]*)?@(?<hostname>(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])):(?<port>\d+)\/(?<database>[a-zA-Z0-9_-]*)/ | |||
| ~r/\w*:\/\/(?<username>[a-zA-Z0-9-*#!%^&$_.]*):(?<password>[a-zA-Z0-9-*#!%^&$_.]*)?@(?<hostname>(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])):(?<port>\d+)\/(?<database>[a-zA-Z0-9_-]*)/ | |||
There was a problem hiding this comment.
@abezard-conduit it looks, suggested change is too broad to the considered case. I'd suggest adding only "." to the regular expression. Will it be enough to cover IAM-based user creation?
There was a problem hiding this comment.
From the issue it seems that most needed character is @
With this I faced a following problem: since we decode URL before we extract parameters regular expression fails to extract parameters because the format becomes broken due to unexpected @, so the change that requires most attention is decoding after extracting parameters. Would it break anything, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9589