Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate indexer setup #10032

Merged
merged 5 commits into from
May 14, 2024
Merged

fix: Separate indexer setup #10032

merged 5 commits into from
May 14, 2024

Conversation

Qwerty5Uiop
Copy link
Collaborator

@Qwerty5Uiop Qwerty5Uiop commented May 7, 2024

Resolves #9254
Resolves #8890

Changelog

  • Updated Chain.indexed_ratio_blocks/0 to use last block from DB to indicate if indexer is running instead of DISABLE_INDEXER env.
  • Removed old UI appearance in case of DISABLE_WEBAPP=true.
  • Fixed Explorer.Chain.Events.Listener enabled logic so it will be started in API setup.
  • Added DISABLE_API env variable. If set, BlockScoutWeb application won't start at all.
  • Renamed INDEXER_INTERNAL_TRANSACTIONS_INDEXING_FINISHED_THRESHOLD to API_INTERNAL_TRANSACTIONS_INDEXING_FINISHED_THRESHOLD since it's used only for user requests.

Docs update: blockscout/docs#278, blockscout/docs#279

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_indexing?/1 works impropelry - it returns true, if indexer is disabled. So, it will always true in the setup with separated indexer and API pods.

Copy link
Member

@vbaranov vbaranov May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the same issue is true with indexed_ratio_internal_transactions/0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed in 57501f5

@vbaranov vbaranov merged commit 2e4e2ec into master May 14, 2024
16 checks passed
@vbaranov vbaranov deleted the ap-indexer-api-split branch May 14, 2024 15:31
fedor-ivn added a commit that referenced this pull request May 18, 2024
* master: (65 commits)
  fix: Add healthcheck endpoints for indexer-only setup (#10076)
  6.6.0
  fix: Rework revert_reason (#9212)
  fix: Eliminate from_address_hash == #{address_hash} clause for transactions query in case of smart-contracts (#9469)
  feat: Add optional retry of NFT metadata fetch in Indexer.Fetcher.Tok… (#10036)
  fix: Separate indexer setup (#10032)
  feat: Blueprint contracts support (#10058)
  chore: Update hackney pool size: add new fetchers accounting (#9941)
  fix: Disallow batched queries in GraphQL endpoint (#10050)
  feat: Clone with immutable arguments proxy pattern (#10039)
  fix: vyper contracts re-verificaiton (#10053)
  refactor: Refactor get_additional_sources/4 -> get_additional_sources/3 (#10046)
  chore: Bump credo from 1.7.5 to 1.7.6 (#10060)
  chore: Bump redix from 1.5.0 to 1.5.1 (#10059)
  chore: Bump ex_doc from 0.32.1 to 0.32.2 (#10061)
  fix: Fix Unknown UID bug at smart-contract verification (#9986)
  refactor: test database config (#9662)
  chore: remove `has_methods` from `/addresses` (#10051)
  feat: Improve retry NFT fetcher (#10027)
  chore: Add support of Blast-specific L1 OP withdrawal events (#10049)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split indexer and API issues API mode does not broadcast events
2 participants