Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rootstock #2077

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jonathansmirnoff
Copy link

@jonathansmirnoff jonathansmirnoff commented Mar 6, 2024

Description

Add Rootstock to web3-onboard

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@jonathansmirnoff jonathansmirnoff changed the title feat: add rootstock Add Rootstock Mar 6, 2024
@jonathansmirnoff jonathansmirnoff force-pushed the feat/add-rootstock branch 2 times, most recently from 48cbd9a to b6d230b Compare March 6, 2024 17:17
@Adamj1232
Copy link
Member

We are not at this point adding native chains to Web3-Onboard as dapp devs can easily add chains through the initialization object. This is in an effort to keep the modules light and performant.
If you would like to discuss this further and chat about other options @mhchaudhry3

@jonathansmirnoff
Copy link
Author

@Adamj1232 thanks for your response. Can we create telegram group with @mhchaudhry3?

},
'0x1f': {
icon: rootstockIcon,
color: '#8247E5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this color match the color noted above? i.e. #0259F9

},
'0x1f': {
icon: rootstockIcon,
color: '#8247E5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: '#8247E5'
color: '#0259F9'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants