Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing invalid DNS tld entries from malware.txt #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aww-yiss
Copy link

@aww-yiss aww-yiss commented Mar 29, 2024

Signed-off-by: Josh Bradley jbradley@deimos.lan

Summary

Checklist

  • I have verified that I have not modified the following files:
    - inside the adguard folder
    - inside the alt-version folder
    - inside the dnsmasq-version folder
    - everything.txt

Because those files will be automatically updated using GitHub Actions!

Signed-off-by: Josh Bradley <jbradley@deimos.lan>
Copy link
Contributor

@spirillen spirillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove two more records...

malware.txt Outdated Show resolved Hide resolved
malware.txt Outdated Show resolved Hide resolved
@aww-yiss aww-yiss changed the title Removing two invalid DNS entries from malware.txt Removing invalid DNS tld entries from malware.txt Mar 31, 2024
Signed-off-by: aww-yiss <aww-yiss@deimos.lan>
@aww-yiss
Copy link
Author

aww-yiss commented Mar 31, 2024

@spirillen per your observation, there were several malformed entries in here. I've scrubbed all the values to check that they at least end in a valid DNS TLD, which at a minimum responds with a SOA when querying google's 8.8.8.8 resolver.

@spirillen
Copy link
Contributor

@aww-yiss for another time, just use pyfunceble 😏 , then you safe your self a lot of work and google spying

it is as simple as

pyfunceble --syntax -f $file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants