Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remix template #286

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

vmcodes
Copy link
Contributor

@vmcodes vmcodes commented May 31, 2023

关联 Issue

主要改动

  1. feature: remix blocklet template

界面截图

Screenshot from 2023-05-31 02-47-25

检查清单

  • [-] create-blocklet 生成的项目应该可以正常 dev
  • [-] create-blocklet 生成的项目应该可以正常 deploy
  • [-] create-blocklet 生成的项目应该可以正常 upload

@mave99a
Copy link

mave99a commented May 31, 2023

Looks like we should turn our commit template in English to allow more contributors who are not Chinese speaking.

@vmcodes
Copy link
Contributor Author

vmcodes commented May 31, 2023

@mave99a I'm having fun, including a translation could be cool. I don't see a need to remove the original text.

@wangshijun
Copy link
Collaborator

wangshijun commented Jun 2, 2023

@vmcodes I noticed that you included prisma in the ux template, from our usage experience, getting prisma to work when blocklet bundled is a bit tricky, did you make it work in production mode?

@vmcodes
Copy link
Contributor Author

vmcodes commented Jun 2, 2023

@wangshijun I was able to have it work in production, but I noticed one issue that is related to SQLite and not Prisma. If you build the application on Windows and try to deploy it to a Ubuntu server for production there are compatibility issues. This doesn't happen if you build on Ubuntu. The same issue happens with Type ORM. However, I experienced no issues with PostgreSQL and Prisma. It is a confusing situation, I don't mind if you want to close the issue and pull request.

@vmcodes
Copy link
Contributor Author

vmcodes commented Jun 12, 2023

@wangshijun do you want me to merge in the most recent updates, or would like me to close the PR and issue?

@LancelotLewis
Copy link
Collaborator

@wangshijun do you want me to merge in the most recent updates, or would like me to close the PR and issue?

sorry about this PR, I'll find some time to review this PR in this week

remix is an awesome framework, please continue your work on it, thanks!

@vmcodes
Copy link
Contributor Author

vmcodes commented Jun 13, 2023

Thanks @LancelotLewis , I'll merge the main branch. Let me know if there is anything you'd like me to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants