Various small fixes #127

laurentg · 2014-07-02T09:14:15Z

Correct polyline encoding bug for small negative delta (when float c is negative but rounded binary is 0, ~0 = FFFF...)
Polyline encoding: use proper rounding for float to binary conversion, this allow polyline tests copied over from the web to pass properly (also correct few previous tests)
Add distance to walk legs in JSON output, as it seems to be mandatory for existing OTP clients
Remove duplicated initializations in request buffer, zero out the buffer to zero the padding bytes and to make it safer in case somebody add new fields
Output NULL instead of "null" string for plan error when no error to make JSON output compatible with OTP
Replace inexisting (removed?) function in hashgrid unit function.

In qstring.c, the from_hex function was passing a char argument to the isdigit function. However, according to the C standard (draft N1570), "the argument is an int, the value of which shall be representable as an unsigned char or shall equal the value of the macro EOF. If the argument has any other value, the behavior is undeﬁned". Since char can either be signed or unsigned, casting a char to an int could lead to negative values (unequal to EOF) being passed to the isdigit function. This problem was showing up as a cryptic GCC warning about array indexes, but as it turned out, it was actually a signedness issue instead.

When a user specified a search departing after 12:00:03, this would actually be interpreted as 12:00:00. This commit stores information about rounding inside formerly unused padding bytes in the router request.

…emlabs#97

Using the LL suffix on 1000LL we enforce this. On 64bit the value will by definition be 64bit.

…ain time and at what stop a transfer takes place.

Because I hate the fact that whitespace still occur in the commits.

Remove redundant initializations.

Bug when rounded binary is exactly 0 and c is negative.

This field seems to be mandatory in existing OTP clients.

This align with unit testing results from the web. Add unit-testing for small neg delta.

koch-t · 2014-12-09T01:50:22Z

Sorry, this was a side-effect from a recovery needed after a @skinkie cock-up

abyrd and others added 30 commits November 16, 2013 13:39

initial commit of intset

861ca16

Fix testerrrr usage message

6a8d50c

Mac OS X-compatible sockets

e0c81fd

Remove unnecessary embedded '\0's in strftime call

6ae561c

Merge branch 'pointers'

61975dd

Get the round function out of router_route.

c07b88f

Fix minor mistakes in binheap.c

9c7fe73

Fix types that GCC complains about

305f634

Remove tautological assertions in trie.c

bc08474

Initialize variables safely in router.c

8132e8f

Improve robustness of binheap.c

234a10d

Simplify bitset.c

374adbb

Fix types in test_polyline.c

18f5719

add linked list implementation

5ab27e7

factoring out route reversal code, first commit

b5b0f8d

Round time upwards iff searching with depart after

2fb894a

When a user specified a search departing after 12:00:03, this would actually be interpreted as 12:00:00. This commit stores information about rounding inside formerly unused padding bytes in the router request.

Order transfers by increasing distance

5e0bf7a

Prefer sizeof instead of strlen for preallocated strings. Close bliks…

681883a

…emlabs#97

@JordenVerwer is right.

be6d27b

Some people should not write webservers

33922d1

Add license info to readme

03c6e41

add license headers and LICENSE file

f7cfed1

Update README.md

15e8e9a

wrap license text

5b1b7bf

fix pointer calling

ff8524a

Fix compile issues with reversal.c

bf01793

Implement searching for agencies from explorer.

01c0210

On 32bit machines the * 1000 of the timestamp requires a int64.

7711ba6

Using the LL suffix on 1000LL we enforce this. On 64bit the value will by definition be 64bit.

Adds the visualisation code to the repository, and update the makefile.

d8559d6

skinkie and others added 13 commits February 28, 2014 23:05

Implements the ability to filter on an agency.

5afa2a7

Generate a random stop for a specific agency

75c8e38

tabs to spaces

a109c34

Implements a mode to show which walk transfers are prefered at a cert…

53a577b

…ain time and at what stop a transfer takes place.

Whitespace fix commit.

b0c534d

Because I hate the fact that whitespace still occur in the commits.

Update README.md

7fddb50

Improve error handling of agency_id gtfs fails, bliksemlabs#117

5a23503

Initialize to zero request buffer.

4cc1eee

Remove redundant initializations.

Use NULL for no error on JSON output.

d16adb6

Solve polyline bug when delta is neg and near 0.

3968315

Bug when rounded binary is exactly 0 and c is negative.

Ouput distance in WALK legs.

41114b2

This field seems to be mandatory in existing OTP clients.

Polyline encoding: use proper rounding.

8bbbf6a

This align with unit testing results from the web. Add unit-testing for small neg delta.

Replace reference to inexisting function in tests.

a1f4e66

skinkie force-pushed the master branch from 81b4afa to 5c60d9d Compare December 9, 2014 01:43

koch-t closed this Dec 9, 2014

koch-t reopened this Dec 9, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various small fixes #127

Various small fixes #127

laurentg commented Jul 2, 2014

koch-t commented Dec 9, 2014

Various small fixes #127

Are you sure you want to change the base?

Various small fixes #127

Conversation

laurentg commented Jul 2, 2014

koch-t commented Dec 9, 2014