Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ghome_EP2-A #1854

Merged
merged 2 commits into from Mar 25, 2024
Merged

Update ghome_EP2-A #1854

merged 2 commits into from Mar 25, 2024

Conversation

rovo89
Copy link
Contributor

@rovo89 rovo89 commented Mar 5, 2024

Switch Led_i and LedLinki. After the change, the power status is shown with the green LED and the WiFi status with the blue LED.

Switch Led_i and LedLinki. After the change, the power status is shown with the green LED and the WiFi status with the blue LED.
@barbudor
Copy link
Contributor

barbudor commented Mar 6, 2024

As far as I understand, this change is not functional but a personal preference

I suggest that you modify your PR to add this template in the text and explaining the difference between both so user can choose which one they prefer

@rovo89
Copy link
Contributor Author

rovo89 commented Mar 6, 2024

I can do that if you prefer, although I always associate the colors this way.
Do you have an example how this can be achieved, especially with the explanatory text?

@barbudor
Copy link
Contributor

barbudor commented Mar 6, 2024

@rovo89 you can add text below
Skip one line and you can add mark down formated text

See that one
https://github.com/blakadder/templates/blob/master/_templates/rocket_R4A4

Add note about LED colors
@rovo89
Copy link
Contributor Author

rovo89 commented Mar 6, 2024

@rodajc
Copy link

rodajc commented Mar 6, 2024

With the modification as proposed by @rovo89 the green LED indicates the power state which is definitely more consistent with other devices and with the original firmware.

When I submitted the first version of the template for this device I copied it from the old Nous A1 as recommended by... @barbudor.

I didn't pay much attention to the LEDs as I didn't know what to expect. I was happy it was switching on and off and submitted the template after changing only the NAME.

IMHO @rovo89 proposes an enhancement I think we should publish as the template to use with this device.

@blakadder blakadder merged commit a25e4d0 into blakadder:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants