Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container scan eligibility and config validations #957

Merged
merged 2 commits into from Oct 2, 2023

Conversation

niravrsynopsys
Copy link
Contributor

@niravrsynopsys niravrsynopsys commented Oct 2, 2023

Description

This PR adds 2 validations to determine if container scan should skip or fail when the CONTAINER_SCAN tool is included in a Detect run (i.e.included in the DetectToolsFilter). The behavior should be as follows:

  • If detect.container.scan.file.path was not provided, Detect should skip container scan without publishing a failure.
  • If detect.container.scan.file.path was provided, however the path was empty, an invalid path/URL was provided or the image could not be resolved/downloaded, Detect should publish a failure for CONTAINER_SCAN. Resolves IDETECT-4078
  • If the BlackDuck version is less than 2023.10.0 for a container scan, Detect should publish a failure. Resolves IDETECT-4076.

Thanks to @dterrysynopsys - the BlackDuck version checking code sections are already implemented in the #955 draft and implemented in the same way in this PR to be re-used.

JIRA

IDETECT-4076
IDETECT-4078

@niravrsynopsys niravrsynopsys merged commit 17192c8 into master Oct 2, 2023
@niravrsynopsys niravrsynopsys deleted the dev/niravr/eligibility-validations branch October 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants