Api token support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
it seems support for API Token was implemented ages ago, but somehow forgotten to be added to SonarManager. As token support is essential in our case and also requested by this issue here, I decided to add a quick change for that.
Initial plan was to upgrade to most recent blackduck-common version (47.0.1 -> 58.0.2) and update sonarqube-plugin-api as well, but due to lack of documentation and tons of breaking API changes in blackduck-common, I just added property handling for api token configuration to SonarManager.
API Token is configured via
sonar.hub.tokenproperty. As long as API Token is configured, it will be used for authentication instead of provided username/password credentials.