Phone home helper api change #417
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static PhoneHomeClient createPhoneHomeClient(IntLogger intLogger, HttpClientBuilder httpClientBuilder, Gson gson, String trackingId) { | ||
| return new PhoneHomeClient(intLogger, httpClientBuilder, gson, trackingId); | ||
| public static PhoneHomeClient createPhoneHomeClient(IntLogger intLogger, HttpClientBuilder httpClientBuilder, Gson gson, String apiSecret, String measurementId) { | ||
| //return new PhoneHomeClient(intLogger, httpClientBuilder, gson, apiSecret, measurementId); |
There was a problem hiding this comment.
I have changed the constructor/API in the phone-home-client to accommodate the GA4 API secret, maintaining the order of parameters used here. Please go ahead and use this new signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
apiSecretandmeasurementIdparameters for creating the phone home helper. Also,PhoneHomeClientobject initialization will change when thephone-home-clientis updated.The changes are no longer compatible with previous method signature of the
createAsynchronousPhoneHomeHelper(). That's why the major version is upgraded.This pull request should be merged when the
phone-home-clientlibrary is updated and ready to use.