New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URI encoding for event.trigger #148
Conversation
@jeffheifetz r? |
you should probably add a test that requires some encoding |
they should be covered now by the updated unit tests as everything gets encoded on the server side |
but the string you are passing doesn't require encoding in the tests that is |
I agree with @nukulb, just add one more test for something that requires encoding (ie JSON) and then I'll r+ |
updated test with encoded strings |
lint, unit tests and functional tests all pass. r+ |
The manual functional tests for blackberry.system (which include battery status events) are failing |
I am also seeing these test fail on the next branch |
tested with packager build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager/55/ and framework build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Framework-event-encoding-fix/1/: no issue was found. |
@Pagey squash it one commit please. |
squashed |
merged manually |
This fix encodes and decodes the data arguments on event.trigger allowing for JSON objects and other information to be passed.
Fixes issue #179