Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URI encoding for event.trigger #148

Closed
wants to merge 1 commit into from
Closed

Conversation

ericpearson
Copy link

This fix encodes and decodes the data arguments on event.trigger allowing for JSON objects and other information to be passed.

Fixes issue #179

@ericpearson
Copy link
Author

@jeffheifetz r?

@nukulb
Copy link

nukulb commented Aug 28, 2012

you should probably add a test that requires some encoding

@ericpearson
Copy link
Author

they should be covered now by the updated unit tests as everything gets encoded on the server side

@nukulb
Copy link

nukulb commented Aug 29, 2012

but the string you are passing doesn't require encoding in the tests that is

@jeffheifetz
Copy link

I agree with @nukulb, just add one more test for something that requires encoding (ie JSON) and then I'll r+

@ericpearson
Copy link
Author

updated test with encoded strings

@jeffheifetz
Copy link

lint, unit tests and functional tests all pass. r+

@haahmad
Copy link

haahmad commented Aug 29, 2012

The manual functional tests for blackberry.system (which include battery status events) are failing

@haahmad
Copy link

haahmad commented Aug 29, 2012

I am also seeing these test fail on the next branch

@tracyli
Copy link

tracyli commented Aug 30, 2012

@nukulb
Copy link

nukulb commented Aug 31, 2012

@Pagey squash it one commit please.

@ericpearson
Copy link
Author

squashed

@nukulb
Copy link

nukulb commented Aug 31, 2012

merged manually

@nukulb nukulb closed this Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants