Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename index.coffee to index.coffee.new #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Leptitmanu
Copy link

index.coffe with own customization
M.Ciani Feb 2019

index.coffe with own customization
M.Ciani Feb 2019
@coolajami
Copy link

Hi thanks for sharing
I had a look and there is an issue with the standard folders in the script for the icons. If you get the folder renamed wttr.widget the widget does not work, so I had to manually change all the folder names within the script in order to load the icons. I have the impression there is quite a bit of dead code there, am I correct? I did a bit of tidying up, and I manage to get this result. I can mark it down to your index.coffee if you like me
wttr-new

@caromun101
Copy link

caromun101 commented Feb 21, 2019

Hi thanks for sharing
I had a look and there is an issue with the standard folders in the script for the icons. If you get the folder renamed wttr.widget the widget does not work, so I had to manually change all the folder names within the script in order to load the icons. I have the impression there is quite a bit of dead code there, am I correct? I did a bit of tidying up, and I manage to get this result. I can mark it down to your index.coffee if you like me
wttr-new

Yes, i would love to see this code as a 2nd PR. Thanks coolajami & Leptitmanu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants