[SM-1236] - Add new targets for Go wrapper #772
Conversation
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 177 177
Lines 11501 11501
=======================================
Hits 6751 6751
Misses 4750 4750 ☔ View full report in Codecov by Sentry. |
tangowithfoxtrot
changed the title
tangowithfoxtrot
changed the title
| env: | ||
| RUSTFLAGS: "-D warnings" | ||
| run: cargo build --target ${{ matrix.settings.target }} --release | ||
| run: cargo build -p bitwarden-c --target ${{ matrix.settings.target }} --release |
There was a problem hiding this comment.
I adjusted this workflow so that it only builds the artifacts for the bitwarden-c crate. Let me know if the other builds are actually necessary in this workflow. As far as I can tell, they aren't getting used anywhere else, but I could have missed something
There was a problem hiding this comment.
Yeah, we are only uploading artifacts for files matching *bitwarden_c*, so this seems fine to me.
| env: | ||
| RUSTFLAGS: "-D warnings" | ||
| run: cargo build --target ${{ matrix.settings.target }} --release | ||
| run: cargo build -p bitwarden-c --target ${{ matrix.settings.target }} --release |
There was a problem hiding this comment.
Yeah, we are only uploading artifacts for files matching *bitwarden_c*, so this seems fine to me.
There was a problem hiding this comment.
@tangowithfoxtrot and I discussed how we are adding more toolchains and a desire to reduce the surface in this area. We'll address this idea after this project as Zig has already been introduced in a recent PR.
Thanks for the work on this!
Tracking
SM-1236
Type of change
Objective
Add the following targets to the build workflow:
These are needed to produced statically-linked binaries with our Go language wrapper.
Code changes
bitwarden-ccrate. Previously, it was building every crate in the workspace.Before you submit