Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Display impl instead of ToString #771

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented May 10, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Latest Rust 1.78 includes a clippy warning when implementing ToString directly instead of using Display, which would also derive ToString for free. Note that there are a few uses of impl ToString in the bitwarden-api-* packages but I haven't changed those here. I've opened a PR in openapi-generator OpenAPITools/openapi-generator#18633

Copy link
Contributor

github-actions bot commented May 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsedbb70b8-448b-4dc9-8422-116a9fff74a5

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /release-cpp.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /release-cpp.yml: 67
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 53

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 58.69%. Comparing base (2f52f5e) to head (c88e7c8).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden-exporters/src/lib.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         177      177           
  Lines       11501    11501           
=======================================
  Hits         6751     6751           
  Misses       4750     4750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia requested a review from Hinton May 10, 2024 10:22
@dani-garcia dani-garcia changed the title Use Display iml instead of ToString Use Display impl instead of ToString May 10, 2024
@dani-garcia dani-garcia merged commit e81b5ea into main May 13, 2024
88 checks passed
@dani-garcia dani-garcia deleted the ps/use-display-impl branch May 13, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants