Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1214] Add secrets syncing support to Go #742

Merged
merged 20 commits into from May 16, 2024
Merged

[SM-1214] Add secrets syncing support to Go #742

merged 20 commits into from May 16, 2024

Conversation

Thomas-Avery
Copy link
Contributor

@Thomas-Avery Thomas-Avery commented Apr 26, 2024

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Expose secret syncing to the Go language wrapper.

Code changes

  • crates/bitwarden-json/src/client.rs:
    crates/bitwarden-json/src/command.rs:
    crates/sdk-schemas/src/main.rs:
    Expose secrets sync in schemas

  • languages/go/README.md:
    languages/go/secrets.go:
    Add secrets sync in Go language wrapper.

Before you submit

  • Please add unit tests where it makes sense to do so

@Thomas-Avery Thomas-Avery self-assigned this Apr 26, 2024
@Thomas-Avery Thomas-Avery changed the title [SM-1214] Add secret syncing support to Go [SM-1214] Add secrets syncing support to Go Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.55%. Comparing base (f07d9a7) to head (93a97e3).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden-json/src/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   58.77%   58.55%   -0.22%     
==========================================
  Files         177      178       +1     
  Lines       11501    11544      +43     
==========================================
  Hits         6760     6760              
- Misses       4741     4784      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Logo
Checkmarx One – Scan Summary & Detailse99b8076-57da-486c-8beb-a45a9dfb1149

No New Or Fixed Issues Found

@Thomas-Avery Thomas-Avery requested review from dani-garcia, Hinton and a team April 26, 2024 19:26
@Thomas-Avery Thomas-Avery marked this pull request as ready for review April 26, 2024 19:26
dani-garcia
dani-garcia previously approved these changes Apr 29, 2024
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coltonhurst
coltonhurst previously approved these changes Apr 29, 2024
Base automatically changed from sm/sm-1153-secrets-sync to main May 15, 2024 17:34
@Thomas-Avery Thomas-Avery dismissed stale reviews from coltonhurst and dani-garcia May 15, 2024 17:34

The base branch was changed.

@Thomas-Avery Thomas-Avery merged commit be84bca into main May 16, 2024
104 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-1214 branch May 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants