Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM-1147] Switch to try_init with pyo3_log #676

Merged
merged 2 commits into from Apr 11, 2024
Merged

[SM-1147] Switch to try_init with pyo3_log #676

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c766cea
SM-1147: Try to init logger and fail safely rather than the panic tha…
coltonhurst Mar 21, 2024
4c5b926
SM-1147: Add comment for consistency across crates
coltonhurst Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bitwarden-py/src/client.rs
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
impl BitwardenClient {
#[new]
pub fn new(settings_string: Option<String>) -> Self {
pyo3_log::init();
_ = pyo3_log::try_init();

Check warning on line 11 in crates/bitwarden-py/src/client.rs

View check run for this annotation

Codecov / codecov/patch

crates/bitwarden-py/src/client.rs#L11 

Added line #L11 was not covered by tests
Self(JsonClient::new(settings_string))
}

Expand Down