[PM-6169] Explore potential approach for unknown value in enums #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Hinton
force-pushed
the
ps/enum-unknown
branch
from
b97e365
to
3040e38
Compare
Hinton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We currently don't have a graceful way to handle server adding new enums to fields. Even though the enum might not be used in the SDK. This introduces a default value which allows the consumer to handle it instead.
Showcases two examples of how we might want to handle this:
crates/bitwarden/src/admin_console/policy.rs: Bubble up an error and silently discard invalid policies.-
crates/bitwarden/src/vault/send.rs: Immediately exit execution since we currently require it. In the future this might be refactored to handle it more gracefully.Code changes
Before you submit