Device Login pointer #533
Draft
Device Login pointer #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/bitwarden-crypto/src/enc_string/asymmetric.rs # crates/bitwarden-crypto/src/keys/asymmetric_crypto_key.rs # crates/bitwarden-crypto/src/keys/mod.rs # crates/bitwarden-crypto/src/rsa.rs # crates/bitwarden/src/auth/client_auth.rs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## ps/device-login #533 +/- ##
===================================================
- Coverage 51.48% 51.41% -0.07%
===================================================
Files 163 163
Lines 8168 8178 +10
===================================================
Hits 4205 4205
- Misses 3963 3973 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Explore using an object with pointer instead of exposing the private key.
Before you submit