Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Complete key purpose markers #509

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

POC implementing working marker traits for encryption keys.

Some changes were needed to get this working:

  • Split EncSettings::get_key into get_user_key and get_org_key, to have them typed correctly.
  • Removed the org_uuid param from locate_key, as it didn't make sense anymore.
  • Removed some impls from Encryptable which produced type conflicts with similar impls in KeyEncryptable.
  • Implemented UserEncryption to OrgEncryption conversion to work around a mix up caused by EncryptionSettings using the single org key in secrets manager as the user key. This should be removed once we improve the EncryptionSettings situation.

TODO: Move functions like to_base64 and to_vec to a new Exportable purpose, to limit their use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant