Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
POC implementing working marker traits for encryption keys.
Some changes were needed to get this working:
EncSettings::get_key
intoget_user_key
andget_org_key
, to have them typed correctly.org_uuid
param fromlocate_key
, as it didn't make sense anymore.Encryptable
which produced type conflicts with similar impls inKeyEncryptable
.UserEncryption
toOrgEncryption
conversion to work around a mix up caused by EncryptionSettings using the single org key in secrets manager as the user key. This should be removed once we improve the EncryptionSettings situation.TODO: Move functions like
to_base64
andto_vec
to a newExportable
purpose, to limit their use.