Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SM owned files to code owners #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Thomas-Avery
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Add Secrets Manager owned files to code owners file.

Code changes

  • .github/CODEOWNERS:
    Add Secrets Manager owned files to code owners file.

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (339f45e) 49.34% compared to head (6bd0cb8) 49.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files         154      154           
  Lines        7373     7373           
=======================================
  Hits         3638     3638           
  Misses       3735     3735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this looks good. Open to thoughts that @Hinton might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants