Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out pyo3 for uniffi #473

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Swap out pyo3 for uniffi #473

wants to merge 5 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 4, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Swap out our custom python implementation for uniffi generated bindings. This will allow us to get rid of the pyo3 bindings and our hand written python code. Ultimately simplifying our logic.

Remaining work is to refactor bitwarden-uniffi with two features to properly expose secrets. I believe this effort is worth it, since there are golang and csharp bindgen we can explore utilizing.

Uses maturin to generate the wheels.
Currently blocked by PyO3/maturin#1904.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (793ff10) 46.37% compared to head (88d4c39) 46.29%.
Report is 2 commits behind head on main.

❗ Current head 88d4c39 differs from pull request most recent head 647047e. Consider uploading reports for the commit 647047e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   46.37%   46.29%   -0.08%     
==========================================
  Files         153      153              
  Lines        7054     7080      +26     
==========================================
+ Hits         3271     3278       +7     
- Misses       3783     3802      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant