Expand testing to include sync and models #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 45.21% 52.41% +7.19%
==========================================
Files 153 153
Lines 6918 6918
==========================================
+ Hits 3128 3626 +498
+ Misses 3790 3292 -498 ☔ View full report in Codecov by Sentry. |
Hinton
reviewed
Jan 12, 2024
Comment on lines
+16
to
+23
| pub id: Option<Uuid>, | ||
| pub organization_id: Uuid, | ||
|
|
||
| name: EncString, | ||
| pub name: EncString, | ||
|
|
||
| external_id: Option<String>, | ||
| hide_passwords: bool, | ||
| read_only: bool, | ||
| pub external_id: Option<String>, | ||
| pub hide_passwords: bool, | ||
| pub read_only: bool, |
There was a problem hiding this comment.
The long term aspiration is to not expose this model externally. So I'm a bit hesitant to just make all of these public with that knowledge.
Would it not be sufficient if we verify that the decrypted view matches our expectation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Include some more complex tests of client login/sync/encrypt/decrypt
Some model fields were previously private, so I've had to change them to pub, for now it's not a problem as no one is using the rust models directly.