Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-1138: Update node engine version requirement to: ^18.18.0 #8390

Merged
merged 4 commits into from Mar 22, 2024

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Mar 19, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The typescript-eslint dependency is now above version 7.0, and breaking changes are listed here. Our dependency upgrade PR is here. This PR updates the node.js engine version requirement to ^18.18.0.

Node caret ranges defined here.

Code changes

  • package.json: Update the node.js engine version requirement to ^18.18.0

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@coltonhurst coltonhurst self-assigned this Mar 19, 2024
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 19, 2024
@coltonhurst coltonhurst requested review from a team and coroiu March 19, 2024 16:46
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.41%. Comparing base (4c89156) to head (b487e72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8390   +/-   ##
=======================================
  Coverage   26.41%   26.41%           
=======================================
  Files        2290     2290           
  Lines       67091    67091           
  Branches    12593    12593           
=======================================
  Hits        17719    17719           
  Misses      47990    47990           
  Partials     1382     1382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
@coltonhurst coltonhurst changed the title SM-1138: Update node engine version requirement to: ^18.8.0 SM-1138: Update node engine version requirement to: ^18.18.0 Mar 19, 2024
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coltonhurst coltonhurst removed the needs-qa Marks a PR as requiring QA approval label Mar 21, 2024
@coltonhurst coltonhurst merged commit 0f6d0e4 into main Mar 22, 2024
63 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1138 branch March 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants